coalton-lang / coalton

Coalton is an efficient, statically typed functional programming language that supercharges Common Lisp.
https://coalton-lang.github.io/
MIT License
1.12k stars 67 forks source link

`:coalton/benchmark` deprecated/impendingly deprecated #1204

Open Izaakwltn opened 1 month ago

Izaakwltn commented 1 month ago

The Coalton benchmark library depends on trivial-benchmark, which has recently (2 months ago) gone through a full rewrite.

Quicklisp is still loading a version of trivial-benchmark from October of last year, so until that updates there's no true break as long as you're using quicklisp. If you're manually adding dependencies locally however, this is already a breaking change.

The main changes are the removal of the macros define-benchmark-package and define-benchmark.

I'm planning on tackling this but wanted to open it to discussion.

I think this refactor would also be an opportunity to bolster our benchmark library, and make sure it is included in some facets of CI, at minimum making sure the benchmarks compile, and potentially running benchmarks on new branches, comparing to main.

Izaakwltn commented 1 month ago

Also, similarly to coalton/testing, I think it might be useful to have a coalton/benchmarking library for external coalton programs to have friendly benchmarking.