search

coapjs / node-coap

CoAP - Node.js style
MIT License
531 stars 154 forks source link

chore: move CI to Github Actions #240

Closed JKRhb closed 3 years ago

JKRhb commented 3 years ago

This PR will resolve #224. Tests are now performed on Node versions 10.x, 12.x, 14.x, 15.x, and on multiple platforms (Ubuntu, Windows, Mac OS). One test on Mac OS, however, fails at the moment. This problem should either be fixed or Mac OS should be skipped for testing for now.

The CI pipeline now also generates a coverage report and supports coveralls which can be used for including a badge in the readme. I also thought about including a linting step using JSHint or ESLint but I guess this would require some configuration due to the used coding style.

Apollon77 commented 3 years ago

LGTM

Apollon77 commented 3 years ago

@JKRhb Maybe add in the test a console log temporary to see if thata are not received or only partially or whatever happens

JKRhb commented 3 years ago

@JKRhb Maybe add in the test a console log temporary to see if thata are not received or only partially or whatever happens

The results of the test in question can be seen here. It seems to be an issue with shared sockets

JKRhb commented 3 years ago

I tried out a lot of different parameters now and did not find a reliable way to get the tests to work on Mac OS. I would suggest limiting the CI to Ubuntu and Windows for now (which is an extension of the old testing capabilities) and opening an issue for the remaining tests on Mac OS. Maybe this is actually a more general problem with UDP sockets and NodeJS on Mac OS that has be solved somewhere else.

@mcollina: Could you enable Github Actions for this repository for the changes to take effect?

mcollina commented 3 years ago

this needs to land first, it'd be active on master.