search

coapjs / node-coap

CoAP - Node.js style
MIT License
533 stars 156 forks source link

share-socket tests fail on macos-latest #241

Closed JKRhb closed 3 years ago

JKRhb commented 3 years ago

The share-socket tests currently fail randomly under Mac OS with the following error message: Uncaught Error [ERR_SOCKET_DGRAM_NOT_RUNNING]: Not running

A full test run can be seen here

invaderb commented 3 years ago

I wonder if this is specific to Github actions, my local is on mac-os latest and able to run the tests fine

JKRhb commented 3 years ago

@invaderb That is very good to know! Then I would also assume that this is a Github Actions problem. After your comment I tried the workflow for macOs again in my own fork and it still failed.

They will update macos-latest from 10.15 to 11.0 soon so maybe this will fix the issue (technically it isn't really the "latest" version at the moment). If not it would probably be best to report this problem in an issue in their repository.

invaderb commented 3 years ago

@JKRhb have you re-tested this with macos11 yet?

JKRhb commented 3 years ago

@JKRhb have you re-tested this with macos11 yet?

I just opened #304 to try it out :)

JKRhb commented 3 years ago

Hmm, it as it seems the issue is still present in macos-11 :/

JKRhb commented 3 years ago

@invaderb I now managed to fix the issue by increasing the timeout for the share-socket tests. Maybe we need to further investigate this issue in the future. But for now it should be fixed :)