search

coapjs / node-coap

CoAP - Node.js style
MIT License
533 stars 156 forks source link

fix(server): allow only one server instance for each port number #271

Closed JKRhb closed 3 years ago

JKRhb commented 3 years ago

This PR would fix #268. I am not sure, however, if this change is really necessary/desirable. I am looking forward to any comments on this :)

CC @fillobotto @relu91

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1278390180

Totals Coverage Status
Change from base Build 1273377860: -0.03%
Covered Lines: 1091
Relevant Lines: 1182
💛 - Coveralls
JKRhb commented 3 years ago

Can't we expose this option somewhere? so that we can keep the current behavior but override it when it is needed?

Oh, that is a very good idea! I will add it to the PR :)

JKRhb commented 3 years ago

@relu91 I updated the PR. Would be awesome if you could have a quick look then I'll guess this can be merged :)

JKRhb commented 3 years ago

Looks good! Just remember to update also #278 when this lands 😄

Will do, thanks for the reminder :D

Apollon77 commented 3 years ago

see one comment, but just nitpick