search

coapjs / node-coap

CoAP - Node.js style
MIT License
531 stars 154 forks source link

refactor: remove `simplifyPacketForPrint` function #300

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

This PR removes the simplifyPacketForPrint function from the helpers file. I noticed that this function isn't actually being used and as it causes some trouble when introducing type checking I wanted to propose removing it. I think it was introduced by @Jamezo97 and @invaderb, would this be okay for you? :)

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1315856096

Totals Coverage Status
Change from base Build 1314336199: -0.06%
Covered Lines: 1067
Relevant Lines: 1152
💛 - Coveralls
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1315856096

Totals Coverage Status
Change from base Build 1314336199: -0.06%
Covered Lines: 1067
Relevant Lines: 1152
💛 - Coveralls
JKRhb commented 2 years ago

@Jamezo97 @invaderb I would merge this for now, let me know if there might still be a purpose for this function, then we could move it back in :)

invaderb commented 2 years ago

@JKRhb Sorry was just able to get to this, I don't remember looking at this function all too much, but doing a search in the code base for simplifyPacketForPrint it's only found in the helper JS file and corresponding test file so I agree that this can be removed with no issues.

JKRhb commented 2 years ago

@invaderb Great, thank you for your feedback! :)