search

coapjs / node-coap

CoAP - Node.js style
MIT License
531 stars 154 forks source link

update deps #315

Closed Apollon77 closed 2 years ago

Apollon77 commented 2 years ago

Hm ... should we kick nodejs 10? at least for testing?

JKRhb commented 2 years ago

Hm ... should we kick nodejs 10? at least for testing?

Oh, yeah, after some quick research I think upgrading the node version for the linter workflow could fix the CI pipeline :)

Apollon77 commented 2 years ago

aahh yes the linting was still done in nodejs 10. changed

Apollon77 commented 2 years ago

wtf ... https://github.com/mcollina/node-coap/runs/4122430279?check_suite_focus=true#step:5:4

works locally ... strange

JKRhb commented 2 years ago

Hmm, maybe the error is caused by the caching step?

Apollon77 commented 2 years ago

Caching step? Could be ... lets see

JKRhb commented 2 years ago

Hmm, my other theory would be that it is a node 16 problem. The installation fails under both Ubuntu and Windows using that node version, the others seem to be fine.

Apollon77 commented 2 years ago

what we should do?

Apollon77 commented 2 years ago

PS: (because just noticed it) ... do we need to publish the "test" dir in npm too? (in fact we did)

JKRhb commented 2 years ago

PS: (because just noticed it) ... do we need to publish the "test" dir in npm too? (in fact we did)

Oh, sorry, that is a very good point! I will change that for the typescript version. Or can we publish a 0.26.1 from a different branch?

JKRhb commented 2 years ago

what we should do?

From what I've seen doing another quick search this problem might actually be related to the caching. Maybe we could try to comment that step out

Apollon77 commented 2 years ago

https://github.com/actions/cache/blob/main/examples.md#using-multiple-systems-and-npm-config

Apollon77 commented 2 years ago

But yes I will comment out

JKRhb commented 2 years ago

Okay, my cache theory is disproven :D :/

Apollon77 commented 2 years ago

Ok, reson seems to be the eslint update and other packages ...

JKRhb commented 2 years ago

Maybe downgrading eslint to 7.x.x (for now) could solve the problem?

Apollon77 commented 2 years ago

just did that :-)

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1427706228

Totals Coverage Status
Change from base Build 1427561781: 0.0%
Covered Lines: 1131
Relevant Lines: 1244
💛 - Coveralls
Apollon77 commented 2 years ago

This was it

Apollon77 commented 2 years ago

happy review ;-)