fix: use correct file extension for `models` file

coapjs / node-coap

CoAP - Node.js style

MIT License

531 stars 154 forks source link

fix: use correct file extension for `models` file #324

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

This PR fixes another typescript related bug: As the models file so far used the .d.ts file extension, its contents were ignored during transcompilation, therefore preventing the use of the library in other typescript projects. Renaming the file to models.ts serves as an easy fix to this problem.

While I was at it I added more types from models.ts to the export list in index.ts as missing types also seem to have caused some issues beforehand.

Finally, I incremented the version number to 1.0.2 so that we could release a patched version immediately.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1526312044

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.5%

Totals
Change from base Build 1526043407:	0.0%
Covered Lines:	1138
Relevant Lines:	1251

💛 - Coveralls

JKRhb commented 2 years ago

@Apollon77 Could you maybe have a quick look on this PR? :)

Apollon77 commented 2 years ago

Sorry, lost from radar, merged

Apollon77 commented 2 years ago

You do changelog&tag and I publish... again?

JKRhb commented 2 years ago

You do changelog&tag and I publish... again?

Sounds great :) Changelog and release are created now :)

Apollon77 commented 2 years ago

npm on it's way too.

If you need to "Ping" me directly I could also offer email, telegram, whatsapp or discord as additional communication ways beside Github issues :-)

JKRhb commented 2 years ago

npm on it's way too.

Awesome, thank you :)

If you need to "Ping" me directly I could also offer email, telegram, whatsapp or discord as additional communication ways beside Github issues :-)

That's great! :) Do want to send me an email with your contact information (you can find my address on my profile)? I think using Discord or Telegram would work best for me :)