feat: let `OutgoingMessage` implement `BufferList` interface

coapjs / node-coap

CoAP - Node.js style

MIT License

531 stars 154 forks source link

feat: let `OutgoingMessage` implement `BufferList` interface #326

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

This PR lets the OutgoingMessage transitively implement the Duplex interface from the readable-stream module by adding an implementation of the BufferList interface. This fixes compatibility issues with Node.js stream functions (and incorporates a recent update of the respective types module).

This PR is related to this issue in the node-wot repository.

The PR does not change any functionality, therefore the CI should stay green.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1735858740

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.6%

Totals
Change from base Build 1577779915:	0.0%
Covered Lines:	1139
Relevant Lines:	1251

💛 - Coveralls

JKRhb commented 2 years ago

I just noticed that the bl types module depends on the readable-stream types module, therefore this PR could be simplified :)