Closed JKRhb closed 2 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/server.ts | 1 | 82.48% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 1995369947: | -0.07% |
Covered Lines: | 1142 |
Relevant Lines: | 1259 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/agent.ts | 6 | 7 | 85.71% | ||
<!-- | Total: | 6 | 7 | 85.71% | --> |
Totals | |
---|---|
Change from base Build 1995369947: | -0.01% |
Covered Lines: | 1143 |
Relevant Lines: | 1260 |
This PR (probably) fixes an issue raised in https://github.com/iobroker-community-adapters/ioBroker.philips-air/issues/15 (I think). It seems as if https://github.com/mcollina/node-coap/pull/309 broke handling of the observe option as the value provided by the user is converted into a numeric one while the internal check expects a boolean. I am not entirely sure, yet, if this is the actual fix for the problem but it is probably a step into the right direction.