coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

chore: replace nyc with c8 for code coverage #338

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

Having a look at coveralls.io, I noticed that code coverage seems to be a bit broken right now. I recently found a better tool than nyc called c8 that seems to work with V8's native code coverage capabilities and be used as a drop-in replacement, fixing typescript related issues with nyc. It also gets rid of one additional dev-dependency.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2212862587


Files with Coverage Reduction New Missed Lines %
lib/outgoing_message.ts 1 97.92%
index.ts 2 93.43%
lib/helpers.ts 2 97.07%
lib/observe_read_stream.ts 2 92.21%
lib/observe_write_stream.ts 2 95.1%
lib/cache.ts 3 92.0%
lib/segmentation.ts 3 89.58%
lib/option_converter.ts 4 94.39%
lib/middlewares.ts 5 87.4%
lib/agent.ts 28 87.13%
<!-- Total: 97 -->
Totals Coverage Status
Change from base Build 2201295132: 7.3%
Covered Lines: 8660
Relevant Lines: 9060

💛 - Coveralls
JKRhb commented 2 years ago

Oh, as you can see the improvement above already :) nyc wasn't capable of handling typescript, as it seems.