coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

fix: fix observe when receiving block2 response #343

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

This PR incorporates the suggested change by @Thousif-khan and should fix #336.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2251396779

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 2216214651: -0.4%
Covered Lines: 2821
Relevant Lines: 3033

💛 - Coveralls
JKRhb commented 2 years ago

I think we should probably merge #344 first (which addresses some more fundamental observe issues) and see afterwards if this PR is still needed.

Apollon77 commented 2 years ago

Ok, I release a 1.0.8 with #34 in and then we test again

JKRhb commented 2 years ago

Ok, I release a 1.0.8 with #34 in and then we test again

Awesome, thank you :)

JKRhb commented 2 years ago

Hmm. Not sure if the additional if check changed anything?

Apollon77 commented 2 years ago

Will merge and release tonight. Sorry for the delay