fix: fix problem with observe responses without observe option

coapjs / node-coap

CoAP - Node.js style

MIT License

528 stars 154 forks source link

fix: fix problem with observe responses without observe option #344

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

With this PR I think I finally found the fix for https://github.com/iobroker-community-adapters/ioBroker.philips-air/issues/15: As it turned out, a type check that I had introduced to make sure that only numeric Observe values are passed to the initialization of ObserveStream objects caused them to not be initialized at all.

This PR fixes the issue and illustrates that observing now finally works again with an example using the Eclipse Californium test server.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2214006857

8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 91.749%

Totals
Change from base Build 2213842359:	0.09%
Covered Lines:	2821
Relevant Lines:	3033

coapjs / node-coap

fix: fix problem with observe responses without observe option #344

Pull Request Test Coverage Report for Build 2214006857

💛 - Coveralls