coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

fix: encode 0 in observe option with zero byte length #345

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

This PR should finally fix the issues reported in https://github.com/iobroker-community-adapters/ioBroker.philips-air/issues/15 by encoding a value of zero in observe options with a length of zero bytes (as it has been the case before).

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2341462770

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/agent.ts 26 29 89.66%
<!-- Total: 26 29 89.66% -->
Files with Coverage Reduction New Missed Lines %
lib/server.ts 6 86.51%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 2308841468: -0.4%
Covered Lines: 2840
Relevant Lines: 3053

💛 - Coveralls