coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

fix(agent): correctly handle `false` observe values #346

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

This is a fix for https://github.com/avency/coap-cli/issues/136. The case where the observe parameter is set to false has not been handled correctly, yet, causing clients to hang after a request has been finished.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2348435791

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
lib/server.ts 2 86.94%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 2343713153: -0.4%
Covered Lines: 2840
Relevant Lines: 3053

💛 - Coveralls