search

coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

chore: update tested node versions to 14, 16, and 18 #347

Closed JKRhb closed 2 years ago

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2361219349

Totals Coverage Status
Change from base Build 2350308957: 0.08%
Covered Lines: 2840
Relevant Lines: 3053
💛 - Coveralls
JKRhb commented 2 years ago

@Apollon77 Hmm, seems like Node 18 causes some problems. I think there was a multicast-related API change that causes that?

Apollon77 commented 2 years ago

puuhh ... ist it that "network family parameter change"? Will be reverted in 18.2 as it seems

JKRhb commented 2 years ago

puuhh ... ist it that "network family parameter change"? Will be reverted in 18.2 as it seems

Oh, you mean this one, right? https://github.com/nodejs/node/pull/41431#discussion_r841272416

Apollon77 commented 2 years ago

yes, should be reverted in node.js 18.2

Apollon77 commented 2 years ago

nope ... not fixed by 18.2

JKRhb commented 2 years ago

nope ... not fixed by 18.2

I think the number of errors reduced from 10 to 4, though, so we're at least halfway there ;)

JKRhb commented 2 years ago

The latest version of Node 18 seems to have solved the issue :) So I would merge this PR.