search

coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

fix: keep user-defined options during block2 transfers #366

Closed JKRhb closed 6 months ago

JKRhb commented 1 year ago

Fixes #365.

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 6980365384

Totals Coverage Status
Change from base Build 6980349488: 0.006%
Covered Lines: 2877
Relevant Lines: 3088
💛 - Coveralls
JKRhb commented 1 year ago

I approved, but maybe lets wait if the user can check it

Thank you :) Yeah, let's wait for them. In the meantime, I rebased the PR and squashed the commits into one.

Apollon77 commented 6 months ago

feel free to merge :-)

JKRhb commented 6 months ago

For some reason, the CI fails on Master now for Node.js 20 :/ Will try to investigate that, maybe we need to temporarily revert the merge, though.