coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

chore: remove pre-commit hook #368

Closed JKRhb closed 1 year ago

JKRhb commented 1 year ago

So far, a pre-commit hook was triggered by default that ran npm test whenever you committed. I personally found this a bit annoying and always removed the hooks manually, but due to the configuration in package.json, they are always reinstalled whenever you invoke npm install.

This PR gets rid of the hooks by removing the pre-commit dependency and the pre-commit field in package.json. This gives us developers a bit more control without sacrificing code quality here on GitHub since the CI action is running anyway, ensuring that the code base passes all tests.

This is just a personal preference, though, if you would like to keep the hook, we could also leave it as is and close this PR :)