coapjs / node-coap

CoAP - Node.js style
MIT License
528 stars 154 forks source link

New try to fix the pr for the Fixed build issuee can only be default-imported using the 'esModule #383

Closed JimmyBjorklund closed 5 months ago

JimmyBjorklund commented 5 months ago

https://github.com/coapjs/node-coap/pull/378

JKRhb commented 5 months ago

Thank you, @JimmyBjorklund, now the workflows are working again :) Very weird that the checks weren't running in the other PR 🤔

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8433103350

Details


Totals Coverage Status
Change from base Build 7768545452: 0.002%
Covered Lines: 2878
Relevant Lines: 3089

💛 - Coveralls
JKRhb commented 5 months ago

Hmm, now it seems like there is a Node 20 related issue :/

Apollon77 commented 5 months ago

@JKRhb https://github.com/coapjs/node-coap/issues/380 ?

JKRhb commented 5 months ago

@JKRhb #380 ?

Oh, right 😅 Then I guess we can merge this one and continue working on #380 afterward? :)

Apollon77 commented 5 months ago

ok for me