search

coapp-packages / libpng

http://www.libpng.org/
Other
6 stars 2 forks source link

Request for v140_xp platform toolset/target #4

Open Malvineous opened 8 years ago

Malvineous commented 8 years ago

Along with the current v120 and v140 platform toolsets, would it be possible to add support for v140_xp as well? This is needed if you want your programs to still be able to run under Windows XP.

Currently if you set your platform to v140_xp in Visual Studio 2015 and try to compile a program that uses libpng, you just get a bunch of png-related unresolved external errors.

madewokherd commented 8 years ago

I'll see what I can do.

You might be able to work around it for now by using v140, setting the "Minimum Required Version" to 5.01 in Configuration Properties > Linker > System (also requires specifying a subsystem on the same page), and defining WINVER and _WIN32_WINNT macros to 0x0501. I don't have a copy of Windows XP around to test this.

Malvineous commented 8 years ago

Thanks for that, I'll give it a try, but I'm not confident it will work. The toolset name is different for v140_xp, so all the conditions in the NuGet configuration files will fail as they only match v120 and v140. So I guess you'd have to manually specify all the include paths and library files, for each project.

I was hoping it would be a simple matter of adding v140_xp to the list of toolsets and have everything generated automatically when rebuilding the package, but perhaps not?

madewokherd commented 8 years ago

Looks like the zlib package doesn't support the _xp variations. I will contact the owner of that package through nuget to see if they can add this.

Malvineous commented 8 years ago

That's great, many thanks for looking into this for me. I hope the zlib maintainer is willing to add _xp support!