coapp / coapp.powershell

ClrPlus Signing
52 stars 43 forks source link

Please release VS2015 support #112

Closed forderud closed 4 years ago

forderud commented 9 years ago

The latest publicly available (beta) version of CoApp PowerShell seem to be 1.23.521.0. This version does not support the "v140" pivot required for VS2015 support. Attempting to author a native VS2015 NuGet package exits with the following error: 'Write-NuGetPackage : Unmatched configuration choice 'v140''

Support for VS2015 was merged in September 2014 (https://github.com/coapp/coapp.powershell/pull/89), so this appears to be a question of releasing what is already implemented.

igagis commented 9 years ago

any plans to release this?

igagis commented 9 years ago

I emailed to @fearthecowboy about the issue, let's see if he could help

jmecosta commented 9 years ago

you can define the pivots while release is not done.

configurations 
{
                      // This node contains custom pivot information.

                      Toolset 
                      {
                                                   key : "PlatformToolset"; // this is CoApp pre-defined key
                                                   choices: { v140, v120, v110, v100 };
                      };
}
fearthecowboy commented 9 years ago

I've finally been given time between projects, I'm working on this today.

forderud commented 9 years ago

Any progress on fixing this issue?

NiViktor commented 8 years ago

I am also running into this issue. Any update on when the VS 2015 support will be available? Thanks!

23W commented 8 years ago

When update come out ?

forderud commented 8 years ago

Any progress on fixing this issue?

rchom commented 8 years ago

@jmecosta Where does the "configurations { ... } " workaround go?

jmecosta commented 8 years ago

Before the nuget section

zabulus commented 8 years ago

workaround works bad if I use v140 and v140_xp projects in my solution. for <v140 .targets files had next condition, which matches both v110 and v110_xp:

 ( $(PlatformToolset.ToLower().IndexOf('v110')) &gt; -1

If I use workaround new .targets file contains:

'$(PlatformToolset.ToLower())' == 'v140'

Which unacceptable for my projects. Any thoughts?

jmecosta commented 8 years ago

You can always generate only the prop files with noclean option and the adjust the targets to your needs and generate the nugets yourself?

zabulus commented 8 years ago

I've workarounded my issue by following:

configurations {
    Toolset { 
        key : "PlatformToolset"; 
        choices: { v140 };  
        // Explicitly Not including pivot variants:  "WindowsKernelModeDriver8.0", "WindowsApplicationForDrivers8.0", "WindowsUserModeDriver8.0" 

        // We're normalizing out the concept of the v140 platform -- Overloading the $(PlatformToolset) variable for additional pivots was a dumb idea.
        v140.condition = "( $(PlatformToolset.ToLower().IndexOf('v140')) > -1 Or '$(PlatformToolset.ToLower())' == 'windowskernelmodedriver8.0' Or '$(PlatformToolset.ToLower())' == 'windowsapplicationfordrivers8.0' Or '$(PlatformToolset.ToLower())' == 'windowsusermodedriver8.0' )";
    };
}

CoApp seeks for the condition subsection and patches it's content right in a .targets file.

lgxZJ commented 7 years ago

hasn't fixed yet?

forderud commented 4 years ago

Closing, since this is unlikely to ever be fixed. My team have opted to instead use nuspec & targets files directly instead of coapp.