coapp / coapp.powershell

ClrPlus Signing
52 stars 43 forks source link

Option to disable package splitting (overlay packages) #54

Open yodantauber opened 10 years ago

yodantauber commented 10 years ago

Can I disable package splitting (overlay packages) by specifying something in the *.autopkg file and/or in the CoApp command line? Alternatively, can I control the splitting size threshold?

We need this both for testing purposes, and for creating some packages for internal use within our organization only.

fearthecowboy commented 10 years ago

Yes, -SplitThreshold is the size that it will split on:

Write-NuGetPackage -SplitThreshold 1000000000?

should help you out.


From: yodantauber notifications@github.com Sent: Wednesday, April 02, 2014 6:50 AM To: coapp/coapp.powershell Subject: [coapp.powershell] Option to disable package splitting (overlay packages) (#54)

Can I disable package splitting (overlay packages) by specifying something in the *.autopkg file and/or in the CoApp command line?

We need this both for testing purposes, and for creating packages for internal use within our organization only.

Reply to this email directly or view it on GitHubhttps://github.com/coapp/coapp.powershell/issues/54.

yodantauber commented 10 years ago

Thanks, but I just tried that with version 2.4.493.0. The Power Shell cmdlet accepted the parameter, but it still split the packages.

fearthecowboy commented 10 years ago

Hmm. I thought that worked. sigh

I'll reserve some time to get back to this tomorrow -- I've been working on a top-secret project for the last couple of months that we finally get to talk about today (it's being announced at Build today)

G


From: yodantauber notifications@github.com Sent: Wednesday, April 02, 2014 7:15 AM To: coapp/coapp.powershell Cc: Garrett Serack Subject: Re: [coapp.powershell] Option to disable package splitting (overlay packages) (#54)

Thanks, but I just tried that with version 2.4.493.0. The Power Shell cmdlet accepted the parameter, but it still split the packages.

Reply to this email directly or view it on GitHubhttps://github.com/coapp/coapp.powershell/issues/54#issuecomment-39335005.

yodantauber commented 10 years ago

Oops, sorry, my bad. Turns out the entire Boost package is actually bigger than 1,000,000,000 bytes uncompressed!

fearthecowboy commented 10 years ago

?Ohh. oooooh.

That's big.

I foolishly made that parameter an int32 -- so it can handle up to 2.1 gb I guess.

G


From: yodantauber notifications@github.com Sent: Wednesday, April 02, 2014 7:21 AM To: coapp/coapp.powershell Cc: Garrett Serack Subject: Re: [coapp.powershell] Option to disable package splitting (overlay packages) (#54)

Oops, sorry, my bad. Turns out the entire Boost package is actually bigger than 1,000,000,000 bytes uncompressed!

Reply to this email directly or view it on GitHubhttps://github.com/coapp/coapp.powershell/issues/54#issuecomment-39335662.

yodantauber commented 10 years ago

Hmm, in fact it's 830,000,000 bytes uncompressed. I wonder why changing the threshold from 1,000,000,000 to 2,000,000,000 helped.

fearthecowboy commented 10 years ago

My bad math?

that's actually very strange.

We'll still count that as a bug :D


From: yodantauber notifications@github.com Sent: Wednesday, April 02, 2014 7:23 AM To: coapp/coapp.powershell Cc: Garrett Serack Subject: Re: [coapp.powershell] Option to disable package splitting (overlay packages) (#54)

Hmm, in fact it's 830,000,000 bytes uncompressed. I wonder why changing the threshold from 1,000,000,000 to 2,000,000,000 helped.

Reply to this email directly or view it on GitHubhttps://github.com/coapp/coapp.powershell/issues/54#issuecomment-39335946.

yodantauber commented 10 years ago

Oh, and indeed this 32-bit variable is a problem with Qt, IPP and MKL (they are split even with the maximal threshold).

fearthecowboy commented 10 years ago

?I'll add a -nosplit option to just bypass the problem entirely.

(this had to happen during //Build, didn't it!? ) ;)

?


From: yodantauber notifications@github.com Sent: Wednesday, April 02, 2014 8:03 AM To: coapp/coapp.powershell Cc: Garrett Serack Subject: Re: [coapp.powershell] Option to disable package splitting (overlay packages) (#54)

Oh, and indeed this 32-bit variable is a problem with Qt, IPP and MKL (they are split even with the maximal threshold).

Reply to this email directly or view it on GitHubhttps://github.com/coapp/coapp.powershell/issues/54#issuecomment-39341192.

yodantauber commented 10 years ago

I've found the problem: the SplitThreshold parameter of Write-NuGetPackage is actually in MB, not bytes, and it overflows silently when it is multiplied by 1024*1024.

WriteNugetPackage.cs, line 100:

script.SplitThreshold = SplitThreshold * 1024 * 1024;

Should be:

script.SplitThreshold = (long)SplitThreshold * 1024 * 1024;
23W commented 8 years ago

The package with disabled splitting works better. In VS2015 C++ solutions with installed splited packages not work IntelliSense. So, it is good proposition for author to disable package splitting by default.Non splitted package works better.