coar-notify / notify.coar-repositories.org

Sources for the COAR Notify website
Creative Commons Attribution 4.0 International
3 stars 1 forks source link

Changes in Notify protocol after DSpace implementation #25

Open steph-ieffam opened 2 months ago

steph-ieffam commented 2 months ago

Hello, I recently noticed that the protocol has changed in the Rejection/Acceptance patterns. The current pattern implementation is 2024-06-20_16-46_1 2024-06-20_16-46 but the old ones were using this longer format:

  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://purl.org/coar/notify"
  ],
  "actor": {
    "id": "https://review-service.com",
    "name": "Review Service",
    "type": "Service"
  },
  "context": {
    "id": "https://dspace-coar.4science.cloud/items/24d50450-9ff0-485f-82d4-fba1be42f3f9",
    "ietf:cite-as": "https://doi.org/10.5555/12345680",
    "type": "sorg:AboutPage",
    "url": {
      "id": "https://research-organisation.org/repository/preprint/201203/421/content.pdf",
      "mediaType": "application/pdf",
      "type": [
        "Article",
        "sorg:ScholarlyArticle"
      ]
    }
  },
  "id": "urn:uuid:5fb3af44-d4f8-4226-9475-2d09c2d8d9e0",
  "inReplyTo": "urn:uuid:f7289ad5-0955-4c86-834c-fb54a736778b",
  "object": {
    "id": "urn:uuid:0370c0fb-bb78-4a9b-87f5-bed307a509dd",
    "object": "https://research-organisation.org/repository/preprint/201203/421/",
    "type": [
      "Offer",
      "coar-notify:ReviewAction"
    ]
  },
  "origin": {
    "id": "https://httpdump.app/dumps/29fc0d4c-aa11-4107-9f1f-e733d569f274",
    "inbox": "https://httpdump.app/dumps/29fc0d4c-aa11-4107-9f1f-e733d569f274",
    "type": "Service"
  },
  "target": {
    "id": "https://research-organisation.org/repository",
    "inbox": "https://research-organisation.org/inbox/",
    "type": "Service"
  },
  "type": [
    "TentativeReject",
    "coar-notify:ReviewAction"
  ]
}

I have noticed some sections were removed and the type has also changed. You have moved from String array to String. As far as improvements are fine and useful keep in mind that we have developed some feature using the previous "version" and this new feature has also been implemented in DSpace 8. Are you sure you want to change the pattern at this point? without even considering creating a version for each "protocol" I think there will be a lot of issues while communicating between systems.

My suggestion is to restore the previous version and create a version 2.0 (or different version naming) with the current changes available on the COAR Notify website. The old patterns were shared with the DSpace community, a Postman collection is also available on the DSpace 8 documentation and uses the previous version.

paulwalk commented 1 month ago

Hi @steph-ieffam

I think there are two (related) issues:

  1. There seems to have been some confusion with the implementation of this pattern - with discrepancies between implementations in HAL, PCI and DSpace. I am trying to clarify the situation and will arrange a call to discuss this.
  2. Versioning. There has been a lot of discussion about how to implement versioning. This is difficult dues to the "loose" nature of the RDF-based protocol. I am currently discussing how we might use JSON schema as a way to make this more precise.