coarchy / stripe

Stripe Component for Moqui based on Coarchy code written by Michael Jones
Other
0 stars 0 forks source link

Directly adding non-prefixed fields to OrderPart seems in poor form #1

Open eigood opened 3 weeks ago

eigood commented 3 weeks ago

https://github.com/coarchy/stripe/blob/3ea626d9b6b4eebbe47a9a0316d92fdba56d2034/entity/StripeEntities.xml#L22

These 2 new values on OrderPart should have stripe as a prefix; "checkoutId"/"checkoutUrl" are too generic, and could clash with other components that want to extend OrderPart.

I'm also not sure about components always adding fields like this directly to OrderPart, for whatever new feature they might be providing. Would rather see an OrderPartSetting entity, that has a typeEnumId, and then the particular value. Seems to be more extensible. And then various views could be used to connect those back to the original query(s).