changed variable naming in CGnet forward method

coarse-graining / cgnet

learning coarse-grained force fields

BSD 3-Clause "New" or "Revised" License

57 stars 26 forks source link

changed variable naming in CGnet forward method #114

Closed brookehus closed 5 years ago

brookehus commented 5 years ago

I changed the variables mentioned in #113. But I still think we need better variables and a #comment for stuff like this:

forward_feat, feat = self.feature(coordinates, embedding_property=embedding_property)

what are forward_feat and feat here? why do we need to do this for the combiner but not otherwise? was deep in coding today and found this hard to work with.

nec4 commented 5 years ago

The variable names and in-line comments are definitely lacking here - will take a look tonight

nec4 commented 5 years ago

LGTM!