Tool to create repulsion priors

coarse-graining / cgnet

learning coarse-grained force fields

BSD 3-Clause "New" or "Revised" License

57 stars 26 forks source link

Tool to create repulsion priors #139

Closed brookehus closed 4 years ago

brookehus commented 4 years ago

Development:

[x] Implement feature / fix bug
[x] Add documentation
[x] Add tests

Checks:
[x] Run nosetests
[x] Check pep8 compliance

WIP. Addresses #138.

brookehus commented 4 years ago

@nec4 I'm gonna write tests for this today or tomorrow morning. If you want to have a look around and give any initial thoughts, let me know!

nec4 commented 4 years ago

I made a PR to this branch (#142) that improves some documentation in priors.py.

brookehus commented 4 years ago

@nec4 I wrote tests! Can you review this?

nec4 commented 4 years ago

I'm on it!

nec4 commented 4 years ago

This is excellent work. All tests pass for me! I just have a few confusions regarding some comments and procedures. Let me know what you think.

brookehus commented 4 years ago

Yay! I addressed all your changes, all of which were great suggestions. I'm so proud of how thorough this review was!! Rerun the tests and let me know if you think we're good to go.

nec4 commented 4 years ago

Thanks for addressing my comments. All tests pass! LGTM!