Closed nec4 closed 4 years ago
This is directly translated from Jiang's original code. We can save the initial coordinates as an attribute or we can make them the starts of the simulations. I might have a slight preference for the former. Presumably since the user is inputting them in the first place they're always knowable. What do you think?
@nec4 if you want to do this differently than it currently is, now is the time for me to make the change in #162. let's discuss.
Given that we didn't change this in the refactor I'm closing the issue. For the record my opinion is that the starting coords should not be saved in the coordinate trajectory for these reasons:
Simulation
class saves them if you want themn
steps and get an n+1
sized result
This is a subtle issue, but the
Simulation
class does not save the initial coordinates. While the save condition is certainly fufilled fort=0
, it saves the coordinates after the very first update. The effect is that the zeroth step coordinates are "jiggled" slightly, but are not the true starting coordinates. Is this the intended behavior? I propose we make a note of this in the class docs. The relevant code lines are below: