Default empty list kwarg in GeometryStatistics

coarse-graining / cgnet

learning coarse-grained force fields

BSD 3-Clause "New" or "Revised" License

56 stars 26 forks source link

Default empty list kwarg in GeometryStatistics #193

Closed nec4 closed 3 years ago

nec4 commented 3 years ago

The parameter bond_pairs in GeometryStatistics has a default value of an empty list. Although we never really use this feature (at least I didn't), empty list defaults are problematic in Python. Instead, this parameter should be set to None by default. I will make a PR for this.