search

coassoftwaresystems / delphi-modbus

Delphi ModbusTCP components
MIT License
119 stars 64 forks source link

Incorrect platform identifier in "ModBusPlatforms.inc" for Delphi XE5 #44

Open toxicdream opened 4 years ago

toxicdream commented 4 years ago

For Delphi XE5 all platform identifiers in System.Classes:

  { Platform identifiers }
  pidWin32        = $0001;
  pidWin64        = $0002;
  pidOSX32        = $0004;
  pidiOSSimulator = $0008;
  pidAndroid      = $0010;
  pidLinux32      = $0020;
  pidiOSDevice    = $0040;

  pidWinNX32      = $0100;

But in ModBusPlatforms.inc witten pidOSX:

{$IFDEF DMB_DELPHIXE3}
  [ComponentPlatformsAttribute(pidWin32 or pidWin64 or
  {$IFDEF DMB_DELPHI10_2_TOKYO}
                               pidLinux32 or pidLinux64 or
  {$ENDIF}
  {$IFDEF DMB_DELPHI10_1_BERLIN}
                               pidiOSDevice32 or pidiOSSimulator32 or
                               pidAndroid32Arm or pidAndroid64Arm or
                               pidiOSDevice64 or pidiOSSimulator64 or
  {$ELSE}
    {$IFDEF DMB_DELPHIXE4}
                               pidiOSDevice or pidiOSSimulator or
    {$ENDIF}
    {$IFDEF DMB_DELPHIXE5}
                               pidAndroid or
    {$ENDIF}
  {$ENDIF}
  {$IFDEF DMB_DELPHI10_3_RIO}
                               pidOSX32 or pidOSX64 or
  {$ELSE}
                               pidOSX or // it is no correct for Delphi XE5
  {$ENDIF}
                               0)] // Make statement complete with 0 (which is harmless)
{$ENDIF}