search

coassoftwaresystems / delphi-modbus

Delphi ModbusTCP components
MIT License
116 stars 63 forks source link

Client: various limits are too short #5

Closed peter-gsellmann closed 8 years ago

peter-gsellmann commented 8 years ago

The client code cuts the request silently without generating exception or error code. Aside from this, the limits are too small. See attached patch

0001-various-limits-are-too-short.patch.txt

peter-gsellmann commented 8 years ago

The Server rejects Bit requests with valid length. The Server returns the wrong length in the answer, so the client detects length inconsistency between request and response.

0001-Error-on-max-length-and-on-returned-length.patch.txt

plpolak commented 8 years ago

Unfortunately I cannot test your changes at the moment, so I have accepted and merged them as is.