coast-team / mute

a scalable collaborative document editor with CRDT, P2P and E2EE
https://mute.loria.fr/
GNU Affero General Public License v3.0
129 stars 17 forks source link

fix(win+docker): updated dockerfile and .dockerignore #114

Closed BaptisteHubert closed 2 years ago

BaptisteHubert commented 2 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Update .dockerignore and Dockerfile. Also a fix for the scripts/get-assets.sh (raised an error when building the application with docker), modified to have LF ending and not CRLF ending (automatic change by git)

What is the current behavior? (You can also link to an open issue here) docker-compose up -d build two containers, and the application is working on the port 4200 of the localhost adress of the user's computer #113

BaptisteHubert commented 2 years ago

Steps for testing this fix :

When i ran the docker-compose command, the application worked.

rigelk commented 2 years ago

@BaptisteHubert you mention the PR as a fix but don't describe the reason behind the fix in the PR body. You did it in the commit message 👍🏾 but please do it in the PR body as well.