search

coastalwhite / lemurs

A customizable TUI display/login manager written in Rust 🐒
Apache License 2.0
652 stars 26 forks source link

Don't assume binary locations #177

Closed antonmosich closed 2 months ago

antonmosich commented 9 months ago

Lemurs has the locations for the X and xauth binaries hardcoded. This does not work with distros which have those binaries in another place (such as NixOS where I encountered this issue). I believe the locations of those binaries shouldn't be hardcoded that way, though I can't tell how it should be done instead. https://github.com/coastalwhite/lemurs/blob/0eb2cda01e2b726c56e6b8c552816ca24cc0b81d/src/post_login/x.rs#L105 https://github.com/coastalwhite/lemurs/blob/0eb2cda01e2b726c56e6b8c552816ca24cc0b81d/src/post_login/x.rs#L147

coastalwhite commented 9 months ago

Thank you for the issue.

I can imagine this causes issues on NixOS. Indeed, this should be changed and is in fact a very small change. I imagine this can just be added to the configuration file. We did the same with the log files.

We would just add:

x11_path = "/usr/bin/X"
xauth_path = "/usr/bin/xauth"

I will see if I can find time to do this.

coastalwhite commented 2 months ago

This is now fixed with #179. In general, I working on getting lemurs ready for NixOS.