search

coax-dev / coax

Modular framework for Reinforcement Learning in python
https://coax.readthedocs.io
MIT License
168 stars 17 forks source link

Add DeepMind Control Suite Example #29

Closed frederikschubert closed 2 years ago

frederikschubert commented 2 years ago

This PR is a rework of https://github.com/coax-dev/coax/pull/26 and adds an example for using SAC on the Walker.walk task from the DeepMind Control Suite.

Depends on https://github.com/coax-dev/coax/pull/27 and https://github.com/coax-dev/coax/pull/28

frederikschubert commented 2 years ago

@KristianHolsheimer This is now ready for review and could get merged into main :)

KristianHolsheimer commented 2 years ago

Thanks so much this Frederik!

Please could you merge #27 and #28, and then rebase? That way it's much easier for me to see which changes are relevant for this specific PR.

KristianHolsheimer commented 2 years ago

I didn't know github could do this, but I just changes the base branch to the one from #28.

KristianHolsheimer commented 2 years ago

@frederikschubert Are you still interested in merging this? I think it would be a great addition to coax!

frederikschubert commented 2 years ago

Yes, I was a bit busy in the last weeks but I will try to finish it as soon as possible :) I will ping you when it’s done!

frederikschubert commented 2 years ago

@KristianHolsheimer I refactored the distribution.

Could you have another look at the code? :)