search

cobalt-org / liquid-rust

Liquid templating for Rust
docs.rs/liquid
MIT License
475 stars 79 forks source link

CI sporadically fails because of `clippy` build failures #110

Closed epage closed 7 years ago

epage commented 7 years ago

Having clippy break the build is great for reviewers since we don't have to run it manually or check the logs. The problem is building clippy can sometimes fail.

I'd suggest making clippy builds not gate the CI but clippy runs would but then how do we know when we have coverage with clippy?

epage commented 7 years ago

Posted on reddit for help with this.

epage commented 7 years ago

Example failures

epage commented 7 years ago

Posted on travis-ci/travis-ci#7167 about a way for locking down nightly+clippy combinations.

epage commented 7 years ago

Well, I guess #120 does technically address this issue even if it means we don't always have clippy coverage.