search

cobalt-uoft / cobalt

Open data APIs for interfacing with public information from the University of Toronto.
https://cobalt.qas.im
MIT License
98 stars 20 forks source link

Updated error codes to be more descriptive #86

Closed phil-bystrican closed 8 years ago

phil-bystrican commented 8 years ago

Updated error codes from 400 to something more descriptive (in this case 404 or 422).

qasim commented 8 years ago

This is a really great change 👍 we just need to update the tests so they expect the right error code.

phil-bystrican commented 8 years ago

These tests need to be updated for this to pass CI

athletics/test.js buildings/test.js courses/test.js exams/test.js food/test.js textbooks/test.js transportation/parking/test.js transportation/shuttles/test.js

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1e2feb14559dd86fe875634b3279f3416585bbed on andrewmcewen:errorCodes into 3130211730854b5f52d2c1e855b0352afe814805 on cobalt-uoft:master.

phil-bystrican commented 8 years ago

@qasim We're good to go

qasim commented 8 years ago

@phil-bystrican Nice. 😎

Thanks for the contribution.