Closed anderson202 closed 8 years ago
Can you squash your first 3 commits and capitalize the message? 😬
date
/ end_date
) should also be in ISO 8601 formatYou can use datetime
to find the month (instead of the dictionary you're currently using)
>>> datetime.datetime.strptime('February', '%B').strftime('%m')
'02'
Dates
for these important dates scrapers, the UTM one would be called UTMDates
. I think Calendar was meant for the academic calendars (here's the UTM one for example).Thanks, I'll try and implement the fixes.
Btw, how do I make changes to the commit messages and "squash" the first 3? Still learning how to use git sorry about that.
@anderson202 don't worry about that, I can squash them when I merge this to master
:) (I don't actually know how to do it, but GitHub has a nice button for me when I choose "Merge pull request")
I'll try to review this tomorrow as well.
@kshvmdn +1 to the Dates
class. That can wait for a separate PR though.
git rebase -i head~5
I've implemented a few of the suggested fixes. Not sure if some of the other suggestions was necessary, please let me know if they are or if any more changes are required.
Looks pretty good! There could be a few formatting changes to better follow PEP8, but that can be done at a later point.
One thing that should be changed though is moving it to a dates/
subdirectory since calendar/
is meant for course calendars.
Finally got the chance to try this - it looks good! I found some other small stuff that we may be able to improve on:
session
- Add year and capitalize
date
)date
)I'm looking at the dates and we might see some overlaps between the summer and winter terms, I think the best solution here is to move the session
key into the events
list, so the schema becomes:
"date":String,
"events":[{
"end_date":String,
"session":String,
"campus":String,
"description":String
}]
Other than that, I think this is really good!
Got it, will get them done ASAP.
@kshvmdn good to merge?
@kshvmdn that's fine then.
@anderson202 thanks a lot for contributing. It's the work that people like you put into this that really pushes the project forward.
Implemented UTM important dates scraper