cobalt-uoft / uoft-scrapers

Public web scraping scripts for the University of Toronto.
https://pypi.python.org/pypi/uoftscrapers
MIT License
48 stars 14 forks source link

Add UTM important dates scraper #81

Closed anderson202 closed 8 years ago

anderson202 commented 8 years ago

Implemented UTM important dates scraper

g3wanghc commented 8 years ago

Can you squash your first 3 commits and capitalize the message? 😬

kashav commented 8 years ago
anderson202 commented 8 years ago

Thanks, I'll try and implement the fixes.

Btw, how do I make changes to the commit messages and "squash" the first 3? Still learning how to use git sorry about that.

qasim commented 8 years ago

@anderson202 don't worry about that, I can squash them when I merge this to master :) (I don't actually know how to do it, but GitHub has a nice button for me when I choose "Merge pull request")

I'll try to review this tomorrow as well.

arkon commented 8 years ago

@kshvmdn +1 to the Dates class. That can wait for a separate PR though.

g3wanghc commented 8 years ago

git rebase -i head~5

anderson202 commented 8 years ago

I've implemented a few of the suggested fixes. Not sure if some of the other suggestions was necessary, please let me know if they are or if any more changes are required.

arkon commented 8 years ago

Looks pretty good! There could be a few formatting changes to better follow PEP8, but that can be done at a later point.

arkon commented 8 years ago

One thing that should be changed though is moving it to a dates/ subdirectory since calendar/ is meant for course calendars.

kashav commented 8 years ago

Finally got the chance to try this - it looks good! I found some other small stuff that we may be able to improve on:

Other than that, I think this is really good!

anderson202 commented 8 years ago

Got it, will get them done ASAP.

qasim commented 8 years ago

@kshvmdn good to merge?

kashav commented 8 years ago

@qasim Besides the name/directory thing, it's good to go!

We can fix that in a future PR when adding date scrapers for the other campuses! 👍

qasim commented 8 years ago

@kshvmdn that's fine then.

@anderson202 thanks a lot for contributing. It's the work that people like you put into this that really pushes the project forward.