cobbler / cobblerclient

Cobbler client library in golang
Apache License 2.0
2 stars 5 forks source link

Implement missing functionality #48

Closed SchoolGuy closed 2 months ago

SchoolGuy commented 3 months ago

Fixes #46 Fixes #47

This PR has multiple commits that each on its own tackle a single problem with the client:

The last one could only be improved with generics which I am uncomfortable implementing right now.

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.87% (target: -1.00%) :white_check_mark: 73.02%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (f1cf954b0dd798ab3147080bc4be5a82e546bd96) | 2002 | 934 | 46.65% | | | Head commit (a2f3641e4c2daa91d74ada7a7054d71d2ddcba54) | 2100 (+98) | 998 (+64) | 47.52% (**+0.87%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#48) | 63 | 46 | **73.02%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more