cobbler / cobblerclient

Cobbler client library in golang
Apache License 2.0
2 stars 4 forks source link

Profile: Add three missing fields #54

Closed SchoolGuy closed 1 month ago

SchoolGuy commented 1 month ago

Fixes #53

The three fields were overlooked to be added when completing the functionality of the client. Since "boot_loaders" can be both list and str (due to backend side inheritance) it must be of type interface.

codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.10% (target: -1.00%) :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (0e20c1af1316afa90ef38c22728dffdd731a54d1) | 2108 | 981 | 46.54% | | | Head commit (cff637689e2aa366e0f02cb8e33932ec81f170ed) | 2170 (+62) | 1012 (+31) | 46.64% (**+0.10%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#54) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

SchoolGuy commented 1 month ago

CI is green, change is minimal, the main reviewer is on vacation. Merging with admin privileges.