search

cobbler / koan

koan - kickstart over a network
https://koan.readthedocs.io/en/latest/
GNU General Public License v2.0
42 stars 32 forks source link

passthrough ksdevice=bootif param #62

Open celesteking opened 8 years ago

celesteking commented 8 years ago

Can't get why mangling is needed. User requested bootif, so let it be so.

# cobbler system dumpvars  --name xxx | grep kernel_options
kernel_options : ksdevice=bootif lang=  kssendmac text 

# koan --virt-pxe-boot --system xxx --display
              kernel  : /mirrors/centos/5/os/x86_64/images/pxeboot/vmlinuz
              initrd  : /mirrors/centos/5/os/x86_64/images/pxeboot/initrd.img
     netboot_enabled  : True
      kernel_options  : ks=xx ksdevice=link kssendmac lang= text 
    virt_disk_driver  : raw
           virt_type  : kvm
           virt_path  : fused
      virt_auto_boot  : 1
       virt_pxe_boot  : 1

This code is doing replacement which shouldn't occur:

 1461         # if using ksdevice=bootif that only works for PXE so replace
 1462         # it with something that will work
 1463         options = string.replace(options, "ksdevice=bootif","ksdevice=link")

Thanks.

eduardok commented 8 years ago

Are you saying that ksdevice=link didn't work for you whereas ksdevice=bootif did?

celesteking commented 8 years ago

That's a good question. What if first interface having link won't receive dhcp offer, but second will? How is it gonna behave?