cobbler / libcobblersignatures

Library for working with cobbler signatures
GNU General Public License v2.0
4 stars 5 forks source link

Reimplement CLI with questionary #27

Closed nodeg closed 3 years ago

nodeg commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #27 (0a4aacd) into master (f32cc87) will decrease coverage by 0.22%. The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   52.23%   52.00%   -0.23%     
==========================================
  Files           4        4              
  Lines         649      648       -1     
==========================================
- Hits          339      337       -2     
- Misses        310      311       +1     
Flag Coverage Δ
unittests 52.00% <18.18%> (-0.23%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/cli.py 0.00% <0.00%> (ø)
libcobblersignatures/models/osversion.py 87.77% <92.30%> (-0.68%) :arrow_down:
libcobblersignatures/signatures.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f32cc87...6437e3b. Read the comment docs.

SchoolGuy commented 3 years ago

Codacy may fail in this PR because we are adding TODOs for future PRs. These things are seperated and should not be the concern of this PR.