search

cobbler / libcobblersignatures

Library for working with cobbler signatures
GNU General Public License v2.0
4 stars 5 forks source link

Add option to pretty print the JSON Output #34

Closed SchoolGuy closed 3 years ago

SchoolGuy commented 3 years ago

This should be rebased after PR #33 and then reviewed.

SchoolGuy commented 3 years ago

Splitout of #31

codecov[bot] commented 3 years ago

Codecov Report

Merging #34 (125d412) into main (00d5126) will decrease coverage by 1.08%. The diff coverage is 37.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   51.60%   50.51%   -1.09%     
==========================================
  Files           4        4              
  Lines         655      675      +20     
==========================================
+ Hits          338      341       +3     
- Misses        317      334      +17
Flag Coverage Δ
unittests 50.51% <37.83%> (-1.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/cli.py 0.00% <0.00%> (ø)
libcobblersignatures/signatures.py 96.93% <82.35%> (-3.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00d5126...125d412. Read the comment docs.

SchoolGuy commented 3 years ago

Rebased since PR #33 was merged

SchoolGuy commented 3 years ago

So the context of this PR is not choosing the dataclass type validation library or converting this to a dataclass itself. I will open an issue for discussion for this now. Please rereview this PR what that in mind again if possible @agraul & @meaksh