search

cobbler / libcobblersignatures

Library for working with cobbler signatures
GNU General Public License v2.0
4 stars 5 forks source link

Handle null and default values #37

Closed SchoolGuy closed 3 years ago

SchoolGuy commented 3 years ago

This is a splitout of #31 and needs to be rebased after #36 was merged

This aims to make the master signatures importable from Cobbler and skips exporting default values to save space in the JSON.

SchoolGuy commented 3 years ago

Rebased onto main

codecov[bot] commented 3 years ago

Codecov Report

Merging #37 (334a080) into main (b6df2e8) will decrease coverage by 2.04%. The diff coverage is 7.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   50.36%   48.32%   -2.05%     
==========================================
  Files           5        6       +1     
  Lines         681      716      +35     
==========================================
+ Hits          343      346       +3     
- Misses        338      370      +32
Flag Coverage Δ
unittests 48.32% <7.40%> (-2.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/cli.py 0.00% <0.00%> (ø)
libcobblersignatures/models/osversion.py 80.50% <5.40%> (-6.59%) :arrow_down:
libcobblersignatures/utils.py 13.33% <13.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6df2e8...334a080. Read the comment docs.