cobbler / libcobblersignatures

Library for working with cobbler signatures
GNU General Public License v2.0
4 stars 5 forks source link

Fix array editing in the CLI #40

Closed SchoolGuy closed 3 years ago

SchoolGuy commented 3 years ago

Currently if you try to edit some arrays we have in our datastructures this can lead to:

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (8473284) into main (67c1e0d) will decrease coverage by 1.71%. The diff coverage is 22.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   48.32%   46.61%   -1.72%     
==========================================
  Files           6        6              
  Lines         716      753      +37     
==========================================
+ Hits          346      351       +5     
- Misses        370      402      +32     
Flag Coverage Δ
unittests 46.61% <22.03%> (-1.72%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/cli.py 0.00% <0.00%> (ø)
libcobblersignatures/utils.py 11.76% <33.33%> (-1.57%) :arrow_down:
libcobblersignatures/models/osversion.py 79.91% <71.42%> (-0.60%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67c1e0d...8473284. Read the comment docs.