search

cobbler / libcobblersignatures

Library for working with cobbler signatures
GNU General Public License v2.0
4 stars 5 forks source link

Tests: Add tests for encoding and decoding the objects #42

Closed SchoolGuy closed 3 years ago

SchoolGuy commented 3 years ago

This also includes a fix for osversion which is required because the conversion to set() from list() broke the export.

codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (fc30d52) into main (0e21590) will increase coverage by 6.69%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   46.61%   53.30%   +6.69%     
==========================================
  Files           6        6              
  Lines         753      756       +3     
==========================================
+ Hits          351      403      +52     
+ Misses        402      353      -49
Flag Coverage Δ
unittests 53.30% <66.66%> (+6.69%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libcobblersignatures/cli.py 0.00% <0.00%> (ø)
libcobblersignatures/models/osversion.py 93.90% <100.00%> (+13.98%) :arrow_up:
libcobblersignatures/models/osbreed.py 94.23% <0.00%> (+7.69%) :arrow_up:
libcobblersignatures/utils.py 82.35% <0.00%> (+70.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e21590...fc30d52. Read the comment docs.