search

cobbler / libcobblersignatures

Library for working with cobbler signatures
GNU General Public License v2.0
4 stars 5 forks source link

Add schema for old signatures #65

Closed tiltingpenguin closed 1 year ago

tiltingpenguin commented 1 year ago

This PR aims to add a schema for the old distro_signatures we still support in cobbler and also fix some issues in the schema like required values not being enforced

Fixes https://github.com/cobbler/libcobblersignatures/issues/63

SchoolGuy commented 1 year ago

This PR will get a review from me however, @tiltingpenguin will also state his opinion about my changes. I will work on this PR this evening and he will take it back over tomorrow.

SchoolGuy commented 1 year ago

The failing validations need to be now compared to the main repository and we need to decide what schema we would like to use in the end and what errors need to be fixed where. The schema MUST validate without errors against shipped versions of Cobbler.

tiltingpenguin commented 1 year ago

The validation error in the latest signatures comes from a typo in the signatures in cobbler.github.io which will be fixed by https://github.com/cobbler/cobbler.github.io/pull/179

SchoolGuy commented 1 year ago

@tiltingpenguin Could you please double-check check the changes I did to the mentioned PR yesterday? If that is done I would merge that one and then rerun the actions here.