coblox / bobtimus

an autobot that automatically handles swaps as Bob
Apache License 2.0
1 stars 1 forks source link

Do not hardcode the chainID in EthereumWallet #29

Closed thomaseizinger closed 5 years ago

thomaseizinger commented 5 years ago

This PR fixes #28.

The first commit (c29be78) makes the necessary changes to EthereumWallet. Unfortunately, this was not possible without breaking API changes since fetching the chainID is an async operation. This commit does not have a green build (because of the breaking API changes) but the actual EthereumWallet tests are running.

The second commit (7bc720c) refactors the rest of the code base to make it work with the async initialization of the wallet. This included changing some of the other tests, like Datastore (now FieldDataSource because it doesn't store anything :upside_down_face:). I actually don't know how these tests ever passed in the first place because the required an Ethereum node running but they didn't start one?!