Add tests to ensure the rate logic is correct

coblox / bobtimus

an autobot that automatically handles swaps as Bob

Apache License 2.0

1 stars 1 forks source link

Add tests to ensure the rate logic is correct #33

Closed D4nte closed 5 years ago

da-kami commented 5 years ago

🙃 I feel these tests are pretty much the same except from the input parameters (there are two scenarios though, accept and decline). Would it make sense to have parametrised tests for tests like this? Do we already have parametrised tests in place somewhere?

D4nte commented 5 years ago

Can we not extract this fee logic into a smaller component that is less cumbersome to setup?

I don't see the value in doing this as I expect future changes to bobtimus to be minimals.

D4nte commented 5 years ago

I see a lot of code repetition. Maybe we can indeed look into parameterized testing?

Yeah after thinking about it more I am going to action Thomas' comment.