coblox / bobtimus

an autobot that automatically handles swaps as Bob
Apache License 2.0
1 stars 1 forks source link

Rename `getRateService` to `create...` #64

Closed thomaseizinger closed 5 years ago

thomaseizinger commented 5 years ago

By convention, a "Getter" is usually cheap and doesn't do much, hence we rename the factory method for creating a new instance of the TradeEvaluationService to createTradeEvaluationService to convey that we are creating a new instance here and not just returning (getting) an already existing one.