search

coblox / bobtimus

an autobot that automatically handles swaps as Bob
Apache License 2.0
1 stars 1 forks source link

trades-to-publish API #76

Closed da-kami closed 5 years ago

da-kami commented 5 years ago

Expose trades to publish API on bobtimus. (Decision: "trades" and not "amounts", because it is a trade-offer, alternatively "tradeOffer" would also work, feel free to comment 😃)

fixes #46

bonomat commented 5 years ago

@thomaseizinger: can do so. Such a refactoring on a small monitor is a 🥙

D4nte commented 5 years ago

After some thinking, I thought I'd approve this PR and fix the timestamp logic in a second PR.

I agree with @thomaseizinger's comment regarding splitting the PR.

Do let me know how you want to proceed forward and I am happy to just help ensuring you don't get stuck. I appreciate you took over this PR from Daniel!

thomaseizinger commented 5 years ago

@bonomat Are you happy with the current state? Does this now have all the functionality we want?