search

coblox / nectar

GNU General Public License v3.0
0 stars 1 forks source link

Implement wallet actions and verify that swap::hbit_herc20 works #25

Closed luckysori closed 4 years ago

luckysori commented 4 years ago

This PR finally allows Nectar to execute Hbit<->Herc20 swaps in the role of Bob. This is tested by an integration test, which drove forward the development of the Bitcoin and Ethereum wallets. Keep in mind that the wallets have been developed in a minimal way to fulfil the requirements of the test, so we'll very likely need to do more work after this.

luckysori commented 4 years ago

I assume that we eventually will add refund tests as well to see that the refunding logic works as well (is glued together correctly).

Yes, we should test the other paths. I wonder what would be the best strategy for that. It seems trivial to make it exit straight away, but the intermediate paths appear harder to hit.

luckysori commented 4 years ago

@D4nte: I'm going ahead with the merge. You can keep commenting here and I'll keep it all in mind for the next PR.