search

coblox / nectar

GNU General Public License v3.0
0 stars 1 forks source link

Additional db apis #50

Closed D4nte closed 4 years ago

D4nte commented 4 years ago

Finishes off the DB. There are a number of improvements/cleanup I'd like to do but I'll leave them at todo for now and focus on delivering features.

da-kami commented 4 years ago

Is there a reason why you are not using flush when working with sled? I thought that each Database operation would end with a flush.

As far as I could see from the documentation flush this ensures that everything is actually stored on disk - and there is flush_async as well.

(Might be that I missed this discussion and you already know this...)

D4nte commented 4 years ago

Is there a reason why you are not using flush when working with sled? I thought that each Database operation would end with a flush.

As far as I could see from the documentation flush this ensures that everything is actually stored on disk - and there is flush_async as well.

(Might be that I missed this discussion and you already know this...)

Because flush is not mentioned in the readme and now I don't understand why. No example uses flush.

Indeed, I think we can revert back to making the traits async and using flush_async.

I'll do that in a follow-up PR and create a todo for it.